Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create user #38

Merged
merged 12 commits into from
Oct 5, 2023

refactor(user): application, presentationλ ˆμ΄μ–΄μ—μ„œ 판맀자, ꡬ맀자둜 μœ μ € 뢄리

333b360
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Feature/create user #38

refactor(user): application, presentationλ ˆμ΄μ–΄μ—μ„œ 판맀자, ꡬ맀자둜 μœ μ € 뢄리
333b360
Select commit
Loading
Failed to load commit list.
GitHub Actions / ktlint completed Oct 5, 2023 in 2s

reviewdog [ktlint] report

reported by reviewdog 🐢

Findings (61)

commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt|6 col 1| Wildcard import
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt|13 col 1| Class body should not start with blank line
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt|15 col 27| A multiline expression should start on a new line
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt|6 col 1| Wildcard import
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt|13 col 1| Class body should not start with blank line
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt|15 col 27| A multiline expression should start on a new line
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/UserReaderService.kt|11 col 1| Class body should not start with blank line
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt|24 col 16| Newline expected after opening parenthesis
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt|24 col 30| Parameter should start on a newline
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt|24 col 40| Parameter should start on a newline
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt|24 col 55| Parameter should start on a newline
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt|24 col 72| Parameter should start on a newline
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt|24 col 90| Newline expected before closing parenthesis
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/UserRepository.kt|9 col 5| Expected a blank line for this declaration
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt|4 col 1| Wildcard import
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt|5 col 1| Wildcard import
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt|12 col 1| Class body should not start with blank line
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt|14 col 24| Parameter should start on a newline
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt|14 col 24| Newline expected after opening parenthesis
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt|14 col 81| Missing newline before ")"
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt|14 col 81| Newline expected before closing parenthesis
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt|4 col 1| Wildcard import
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt|5 col 1| Wildcard import
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt|12 col 1| Class body should not start with blank line
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt|14 col 22| Parameter should start on a newline
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt|14 col 22| Newline expected after opening parenthesis
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt|14 col 75| Missing newline before ")"
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt|14 col 75| Newline expected before closing parenthesis
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/UserController.kt|5 col 1| Wildcard import
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/UserController.kt|12 col 1| Class body should not start with blank line
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/UserController.kt|14 col 17| Parameter should start on a newline
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/UserController.kt|14 col 17| Newline expected after opening parenthesis
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/UserController.kt|14 col 43| Missing newline before ")"
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/UserController.kt|14 col 43| Newline expected before closing parenthesis
commerce-api/src/test/kotlin/com/hanghae/commerce/user/application/CustomerWriterServiceTest.kt|18 col 1| Class body should not start with blank line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/application/CustomerWriterServiceTest.kt|27 col 23| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/application/SellerWriterServiceTest.kt|18 col 1| Class body should not start with blank line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/application/SellerWriterServiceTest.kt|27 col 23| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/application/UserReaderServiceTest.kt|24 col 1| Class body should not start with blank line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/application/UserReaderServiceTest.kt|33 col 23| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/application/UserReaderServiceTest.kt|57 col 23| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/domain/UserRepositoryTest.kt|16 col 20| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/domain/UserRepositoryTest.kt|34 col 20| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/domain/UserTest.kt|10 col 1| Class body should not start with blank line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/domain/UserTest.kt|13 col 20| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/domain/UserTest.kt|45 col 9| Missing space after //
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateCustomerRequestTest.kt|11 col 1| Class body should not start with blank line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateCustomerRequestTest.kt|16 col 23| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateCustomerRequestTest.kt|26 col 69| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateCustomerRequestTest.kt|39 col 23| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateCustomerRequestTest.kt|49 col 69| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateCustomerRequestTest.kt|62 col 23| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateCustomerRequestTest.kt|72 col 69| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateSellerRequestTest.kt|11 col 1| Class body should not start with blank line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateSellerRequestTest.kt|16 col 23| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateSellerRequestTest.kt|26 col 67| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateSellerRequestTest.kt|39 col 23| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateSellerRequestTest.kt|49 col 67| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateSellerRequestTest.kt|62 col 23| A multiline expression should start on a new line
commerce-api/src/test/kotlin/com/hanghae/commerce/user/presentation/dto/CreateSellerRequestTest.kt|72 col 67| A multiline expression should start on a new line
commerce-infra/db-main/src/main/kotlin/com/hanghae/commerce/data/domain/UserEntity.kt|5 col 1| Wildcard import

Filtered Findings (3)

commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/UserRepository.kt|8 col 5| Expected a blank line for this declaration
commerce-infra/db-main/src/main/kotlin/com/hanghae/commerce/data/domain/UserEntity.kt|16 col 1| Unexpected blank line(s) in value parameter list
commerce-infra/db-main/src/main/kotlin/com/hanghae/commerce/data/domain/UserEntityRepository.kt|13 col 1| Class body should not start with blank line

Annotations

Check failure on line 6 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt#L6 <standard:no-wildcard-imports>

Wildcard import
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt:6:1: error: Wildcard import (standard:no-wildcard-imports)

Check failure on line 13 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt#L13 <standard:no-empty-first-line-in-class-body>

Class body should not start with blank line
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt:13:1: error: Class body should not start with blank line (standard:no-empty-first-line-in-class-body)

Check failure on line 15 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt#L15 <standard:multiline-expression-wrapping>

A multiline expression should start on a new line
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/CustomerWriterService.kt:15:27: error: A multiline expression should start on a new line (standard:multiline-expression-wrapping)

Check failure on line 6 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt#L6 <standard:no-wildcard-imports>

Wildcard import
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt:6:1: error: Wildcard import (standard:no-wildcard-imports)

Check failure on line 13 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt#L13 <standard:no-empty-first-line-in-class-body>

Class body should not start with blank line
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt:13:1: error: Class body should not start with blank line (standard:no-empty-first-line-in-class-body)

Check failure on line 15 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt#L15 <standard:multiline-expression-wrapping>

A multiline expression should start on a new line
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/SellerWriterService.kt:15:27: error: A multiline expression should start on a new line (standard:multiline-expression-wrapping)

Check failure on line 11 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/UserReaderService.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/UserReaderService.kt#L11 <standard:no-empty-first-line-in-class-body>

Class body should not start with blank line
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/application/UserReaderService.kt:11:1: error: Class body should not start with blank line (standard:no-empty-first-line-in-class-body)

Check failure on line 24 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt#L24 <standard:function-signature>

Newline expected after opening parenthesis
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt:24:16: error: Newline expected after opening parenthesis (standard:function-signature)

Check failure on line 24 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt#L24 <standard:function-signature>

Parameter should start on a newline
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt:24:30: error: Parameter should start on a newline (standard:function-signature)

Check failure on line 24 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt#L24 <standard:function-signature>

Parameter should start on a newline
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt:24:40: error: Parameter should start on a newline (standard:function-signature)

Check failure on line 24 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt#L24 <standard:function-signature>

Parameter should start on a newline
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt:24:55: error: Parameter should start on a newline (standard:function-signature)

Check failure on line 24 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt#L24 <standard:function-signature>

Parameter should start on a newline
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt:24:72: error: Parameter should start on a newline (standard:function-signature)

Check failure on line 24 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt#L24 <standard:function-signature>

Newline expected before closing parenthesis
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/User.kt:24:90: error: Newline expected before closing parenthesis (standard:function-signature)

Check failure on line 9 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/UserRepository.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/UserRepository.kt#L9 <standard:blank-line-before-declaration>

Expected a blank line for this declaration
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/domain/UserRepository.kt:9:5: error: Expected a blank line for this declaration (standard:blank-line-before-declaration)

Check failure on line 4 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt#L4 <standard:no-wildcard-imports>

Wildcard import
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt:4:1: error: Wildcard import (standard:no-wildcard-imports)

Check failure on line 5 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt#L5 <standard:no-wildcard-imports>

Wildcard import
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt:5:1: error: Wildcard import (standard:no-wildcard-imports)

Check failure on line 12 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt#L12 <standard:no-empty-first-line-in-class-body>

Class body should not start with blank line
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt:12:1: error: Class body should not start with blank line (standard:no-empty-first-line-in-class-body)

Check failure on line 14 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt#L14 <standard:parameter-list-wrapping>

Parameter should start on a newline
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt:14:24: error: Parameter should start on a newline (standard:parameter-list-wrapping)

Check failure on line 14 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt#L14 <standard:function-signature>

Newline expected after opening parenthesis
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt:14:24: error: Newline expected after opening parenthesis (standard:function-signature)

Check failure on line 14 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt#L14 <standard:parameter-list-wrapping>

Missing newline before ")"
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt:14:81: error: Missing newline before ")" (standard:parameter-list-wrapping)

Check failure on line 14 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt#L14 <standard:function-signature>

Newline expected before closing parenthesis
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/CustomerController.kt:14:81: error: Newline expected before closing parenthesis (standard:function-signature)

Check failure on line 4 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt#L4 <standard:no-wildcard-imports>

Wildcard import
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt:4:1: error: Wildcard import (standard:no-wildcard-imports)

Check failure on line 5 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt#L5 <standard:no-wildcard-imports>

Wildcard import
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt:5:1: error: Wildcard import (standard:no-wildcard-imports)

Check failure on line 12 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt#L12 <standard:no-empty-first-line-in-class-body>

Class body should not start with blank line
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt:12:1: error: Class body should not start with blank line (standard:no-empty-first-line-in-class-body)

Check failure on line 14 in commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt#L14 <standard:parameter-list-wrapping>

Parameter should start on a newline
Raw output
commerce-api/src/main/kotlin/com/hanghae/commerce/user/presentation/SellerController.kt:14:22: error: Parameter should start on a newline (standard:parameter-list-wrapping)