Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/domain order #46

Merged
merged 35 commits into from
Oct 12, 2023
Merged

Feature/domain order #46

merged 35 commits into from
Oct 12, 2023

Conversation

e-build
Copy link
Contributor

@e-build e-build commented Oct 9, 2023

πŸ“Œ μš”μ•½

  • μ£Όλ¬Έ 도메인 κ΅¬ν˜„

πŸ“• 무엇을 μž‘μ—…ν•˜μ…¨λ‚˜μš”?

  • 버그 μˆ˜μ •
  • κΈ°λŠ₯ 개발
  • λ¦¬νŒ©ν„°λ§
  • λ¬Έμ„œ
  • ν…ŒμŠ€νŠΈ
  • λΉŒλ“œ 및 ν™˜κ²½μ„€μ • κ΄€λ ¨ μž‘μ—…
  • κ·Έ μ™Έμ˜ 경우 κ°„λž΅νžˆ κΈ°μˆ ν•΄μ£Όμ„Έμš”
    • λ ˆλ””μŠ€ μ˜μ‘΄μ„± μΆ”κ°€
    • testcontainer μ˜μ‘΄μ„± μΆ”κ°€

πŸ“– 변경사항

βœ… 체크리슀트

  • ν™˜κ²½λ³€μˆ˜λ₯Ό μž„μ˜λ‘œ μˆ˜μ •ν•˜μ§€ μ•Šμ•˜λ‚˜μš”?
  • λΆˆν•„μš”ν•œ 둜그λ₯Ό μ§€μš°μ…¨λ‚˜μš”?

jimmy.lee added 30 commits October 4, 2023 18:50
# Conflicts:
#	commerce-api/build.gradle.kts
# Conflicts:
#	commerce-infra/db-main/src/main/kotlin/com/hanghae/commerce/data/common/PrimaryKeyEntity.kt
- 재고 검증 둜직 뢄리 -> facade
@e-build e-build self-assigned this Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Test Results

0 tests   0 βœ”οΈβ€ƒβ€ƒ0s ⏱️
0 suites  0 πŸ’€
0 files    0 ❌

Results for commit 6c83d0b.

♻️ This comment has been updated with latest results.

@e-build
Copy link
Contributor Author

e-build commented Oct 9, 2023

λ‘œμ»¬μ—μ„œλŠ” μ •μƒμ μœΌλ‘œ ν†΅κ³Όν•˜λŠ” λ™μ‹œμ„± ν…ŒμŠ€νŠΈ 2κ°œκ°€ 계속 μ‹€νŒ¨κ°€ λœ¨λ„€μš”, 원인 계속 μ°Ύμ•„λ³΄κ² μŠ΅λ‹ˆλ‹€

jimmy.lee added 2 commits October 12, 2023 12:32
# Conflicts:
#	commerce-api/src/test/kotlin/com/hanghae/commerce/user/domain/UserRepositoryTest.kt
#	commerce-infra/db-main/src/main/kotlin/com/hanghae/commerce/data/domain/JpaUserRepository.kt
#	commerce-infra/db-main/src/main/kotlin/com/hanghae/commerce/data/domain/UserEntityRepository.kt
@e-build e-build merged commit b6fbed2 into develop Oct 12, 2023
@e-build e-build deleted the feature/domain-order branch October 12, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant