Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/domain payment #48

Merged
merged 17 commits into from
Oct 13, 2023
Merged

Feature/domain payment #48

merged 17 commits into from
Oct 13, 2023

Conversation

e-build
Copy link
Contributor

@e-build e-build commented Oct 12, 2023

๐Ÿ“Œ ์š”์•ฝ

  • ๊ฒฐ์ œ ๋„๋ฉ”์ธ ๊ตฌํ˜„

๐Ÿ“• ๋ฌด์—‡์„ ์ž‘์—…ํ•˜์…จ๋‚˜์š”?

  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ
  • ๋ฆฌํŒฉํ„ฐ๋ง
  • ๋ฌธ์„œ
  • ํ…Œ์ŠคํŠธ
  • ๋นŒ๋“œ ๋ฐ ํ™˜๊ฒฝ์„ค์ • ๊ด€๋ จ ์ž‘์—…
  • ๊ทธ ์™ธ์˜ ๊ฒฝ์šฐ ๊ฐ„๋žตํžˆ ๊ธฐ์ˆ ํ•ด์ฃผ์„ธ์š”

๐Ÿ“– ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • ์Šคํ”„๋ง ์ด๋ฒคํŠธ ํ™œ์šฉ
    • ๊ฒฐ์ œ ์™„๋ฃŒ -> ์ฃผ๋ฌธ ๋„๋ฉ”์ธ์—์„œ ์ฃผ๋ฌธ ์ƒํƒœ ๋ณ€๊ฒฝ
  • ์„œํ‚ท๋ธŒ๋ ˆ์ด์ปค ํ™œ์šฉ

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ํ™˜๊ฒฝ๋ณ€์ˆ˜๋ฅผ ์ž„์˜๋กœ ์ˆ˜์ •ํ•˜์ง€ ์•Š์•˜๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ๋กœ๊ทธ๋ฅผ ์ง€์šฐ์…จ๋‚˜์š”?

jimmy.lee added 17 commits October 9, 2023 23:31
# Conflicts:
#	commerce-api/src/test/kotlin/com/hanghae/commerce/user/domain/UserRepositoryTest.kt
#	commerce-infra/db-main/src/main/kotlin/com/hanghae/commerce/data/domain/JpaUserRepository.kt
#	commerce-infra/db-main/src/main/kotlin/com/hanghae/commerce/data/domain/UserEntityRepository.kt
# Conflicts:
#	commerce-api/src/test/kotlin/com/hanghae/commerce/order/application/OrderCreateFacadeTest.kt
@e-build e-build requested review from sm9171 and 5Hanui October 12, 2023 03:48
@e-build e-build self-assigned this Oct 12, 2023
@github-actions
Copy link

Test Results

0 testsโ€‚โ€ƒโ€ƒ0 โœ”๏ธโ€ƒโ€ƒ0s โฑ๏ธ
0 suitesโ€ƒโ€ƒ0 ๐Ÿ’ค
0 filesโ€„โ€‚โ€ƒโ€ƒ0 โŒ

Results for commit 19d8797.

@5Hanui 5Hanui merged commit fc304e5 into develop Oct 13, 2023
5 of 6 checks passed
@e-build e-build deleted the feature/domain-payment branch October 22, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants