Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Notify when a player join/leave your lobby #2653

Open
wants to merge 6 commits into
base: beta
Choose a base branch
from

Conversation

superhize
Copy link
Contributor

@superhize superhize commented Oct 3, 2024

What

Previously:

Changelog New Features

  • Notify you in chat when a marked player join/leave your lobby. - HiZe

Copy link
Contributor

@martimavocado martimavocado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you had some small typos

superhize and others added 3 commits October 3, 2024 16:41
…er/MarkedPlayerConfig.java

Co-authored-by: martimavocado <39881008+martimavocado@users.noreply.github.com>
…er/MarkedPlayerConfig.java

Co-authored-by: martimavocado <39881008+martimavocado@users.noreply.github.com>
…er/MarkedPlayerConfig.java

Co-authored-by: martimavocado <39881008+martimavocado@users.noreply.github.com>
@hannibal002 hannibal002 added this to the Version 0.28 milestone Oct 5, 2024
public Property<String> playersList = Property.of("hypixel,Minikloon");

@Expose
@ConfigOption(name = "Use Prefix", desc = "Should the [SkyHanni] prefix should be in the join/leave message ?")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting around the question mark is incorret

@CalMWolfs CalMWolfs changed the title Add: Notify when a player join/leave your lobby Feature: Notify when a player join/leave your lobby Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants