Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature + Improvement: Hoppity Event Card Live Display #2749

Open
wants to merge 39 commits into
base: beta
Choose a base branch
from
Open

Feature + Improvement: Hoppity Event Card Live Display #2749

wants to merge 39 commits into from
+562 −106

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Oct 16, 2024 •
edited
Loading

What

Adds an option to display the Hoppity Event 'Card' in real-time in a renderable.
Also adds Rabbit the Fish finds and Leaderboard Change as trackable stats.
Removed /shhoppitystats in favor of the GUI, as it's in every way better.

Images

image

image

image

image

image

Changelog New Features

  • Added ability to display Hoppity Event Card in real-time in a GUI element. - Daveed
    • Replaced /shhoppitystats (can be used to view past events).
    • Can be configured to toggle visibility with a keybind.

Changelog Improvements

  • Added two new tracked stats to Hoppity Event Card. - Daveed
    • Rabbit the Fish finds (from Meal Eggs).
    • Chocolate leaderboard change during event.
      • Can optionally set reminders to switch servers to update this stat.

@CalMWolfs CalMWolfs modified the milestones: Version 0.29, Version 0.28 Oct 16, 2024
@DavidArthurCole DavidArthurCole changed the title Feature: Hoppity Event Card Live Display Feature & Improvement: Hoppity Event Card Live Display Oct 22, 2024
@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Title issues:
PR categories shouldn't be separated by '/' or '&', use ' + ' instead

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added Wrong Title/Changelog There is an error in the title or changelog and removed Wrong Title/Changelog There is an error in the title or changelog labels Oct 22, 2024
@DavidArthurCole DavidArthurCole changed the title Feature & Improvement: Hoppity Event Card Live Display Feature + Improvement: Hoppity Event Card Live Display Oct 22, 2024
@DavidArthurCole
Copy link
Contributor Author

Taking this back to draft while I over-engineer some more stuff.

@DavidArthurCole DavidArthurCole marked this pull request as draft October 24, 2024 04:09
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 25, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 25, 2024
@DavidArthurCole DavidArthurCole marked this pull request as ready for review October 26, 2024 02:45
@DavidArthurCole
Copy link
Contributor Author

image
image

removed /shhoppitystats, this supersedes it.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 26, 2024
@hannibal002
Copy link
Owner

Additional idea: option to only show the display as GUI while holding an Egglocator in hand

@DavidArthurCole
Copy link
Contributor Author

Additional idea: option to only show the display as GUI while holding an Egglocator in hand

added

@DavidArthurCole
Copy link
Contributor Author

image

Finished screen shot. Did a lot of work on formatting and all that.

ItsEmpa
ItsEmpa suggested changes Oct 26, 2024
View reviewed changes
src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityEventSummary.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityEventSummary.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityEventSummary.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityEventSummary.kt Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityEventSummary.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityEventSummary.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.java Show resolved Hide resolved
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 26, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 Awaiting requested review from hannibal002

@ItsEmpa ItsEmpa Awaiting requested review from ItsEmpa

Assignees
No one assigned
Labels
Soon This Pull Request will be merged within the next couple of betas
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidArthurCole @hannibal002 @ItsEmpa @CalMWolfs