Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Add in event handler check to SkyHanni Events #2755

Merged
merged 4 commits into from
Oct 26, 2024

Conversation

CalMWolfs
Copy link
Collaborator

@CalMWolfs CalMWolfs commented Oct 18, 2024

What

Added the in event handler functionality that lorenz event has to skyhanni events. Also added a description to it so people (me) could understand why its used.

RepoPatternManager had the in dev environment variable removed as it was only used for this and both in event handler functions check for dev environment through platform utils

Changelog Technical Details

  • Added an event handler check to SkyHanni Events. - CalMWolfs

@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Oct 18, 2024
@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Oct 18, 2024
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Oct 18, 2024
@hannibal002 hannibal002 added test and removed test labels Oct 18, 2024
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Oct 24, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + test to see if changelog verification is fixed
Change should start with a capital letter in text: test to see if changelog verification is fixed
Change should end with a full stop in text: test to see if changelog verification is fixed

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 24, 2024
@hannibal002 hannibal002 merged commit 697e9e2 into hannibal002:beta Oct 26, 2024
9 of 10 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Oct 26, 2024
@CalMWolfs CalMWolfs deleted the in-event-handler branch October 26, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants