Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: itempickup log #2813

Open
wants to merge 7 commits into
base: beta
Choose a base branch
from

Conversation

catgirlseraid
Copy link
Contributor

@catgirlseraid catgirlseraid commented Oct 25, 2024

Dependencies

What

Simplify the code by not checking 9th slot instead of checking every item to see if it is blacklisted
Also add support for armour and bits

Changelog Improvements

  • Added bits and armour to pickup log. - phoebe

catgirlseraid and others added 5 commits October 25, 2024 21:50
simplify the code by not checking 9th slot instead of checking every item to see if it is blacklisted
@catgirlseraid catgirlseraid marked this pull request as ready for review October 26, 2024 09:26
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Oct 26, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Added bits and armour to pickup log

Title issues:
Unknown category: 'Improve', valid categories are: Feature, Improvement, Fix, Backend, Remove and expected categories based on your changes are: Improvement

Please fix these issues. For the correct format, refer to the pull request template.

@catgirlseraid catgirlseraid changed the title Improve: itempickup log Improvement: itempickup log Oct 26, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Added bits and armour to pickup log

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 26, 2024
Copy link

One or more Detekt Failures were detected:

  • BitsAPI.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
  • BitsAPI.kt#L3: Unnecessary long whitespace
  • FameRanks.kt#L10: A member is named after the object. This might result in confusion. Please rename the member.

@CalMWolfs CalMWolfs added this to the Version 0.29 milestone Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants