Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin setuptools to work around build error with PyPy 3 #202

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

anthrotype
Copy link
Member

No description provided.

@anthrotype anthrotype mentioned this pull request Aug 22, 2024
@anthrotype anthrotype changed the title [DO NOT MERGE] empty commit to trigger CI [DO NOT MERGE] debug build issue with PyPy 3.8 Aug 22, 2024
@anthrotype anthrotype changed the title [DO NOT MERGE] debug build issue with PyPy 3.8 [DO NOT MERGE] trying to debug build issue with PyPy 3.8 Aug 22, 2024
@anthrotype anthrotype changed the title [DO NOT MERGE] trying to debug build issue with PyPy 3.8 [WIP] trying to debug build issue with PyPy 3.8 Aug 22, 2024
@anthrotype
Copy link
Member Author

I was able to reproduce the TypeError: 'NoneType' object is not subscriptable (key slice(None, None, None)) with PyPy 3.9 installed locally on my linux machine. It seems to be a bug or regression in setuptools' integration with pypy because I can trigger it with very simple extension modules.

@anthrotype
Copy link
Member Author

it looks like this only happens with setuptools >= 72.2 (current is 73.0.1). If we pin to setuptools<72.2 in pyproject.toml it works. I'll do that for now, and file a bug upstream tomorrow

@anthrotype
Copy link
Member Author

so yeah it's confirmed this is a regression in setuptools (actually in the vendored distutils module): pypa/distutils#283

let's pin setuptools for the time being

only with setuptools >= 72.2 we get the "TypeError: 'NoneType' object is not subscriptable (key slice(None, None, None))" error when building the extension module on PyPy 3.8+ on Linux and MacOS.

fixup
@anthrotype anthrotype changed the title [WIP] trying to debug build issue with PyPy 3.8 pin setuptools to work around build error with PyPy 3 Aug 23, 2024
@anthrotype anthrotype merged commit e66c546 into main Aug 23, 2024
3 checks passed
@anthrotype anthrotype deleted the test-ci branch August 23, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant