-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ot-metrics #204
Conversation
thanks!
what's different/special about those as far as testing is concerned? |
Looking at the source, they seem to scale the returned values based on |
get_y_variations
After thinking about this I added a mundane test for each of the methods. Given that uharfbuzz is a very thin layer over HarfBuzz, that's probably fine. Even if these methods aren't useful now, perhaps future additions will make them so. |
I’m not familiar with this API, to be honest. |
fwiw i'd be fine with merging this as is |
If it passes review, including verifying that I'm calling each method I added in the tests in a somewhat substantive way, I think it will be fine. |
Co-authored-by: خالد حسني (Khaled Hosny) <khaled@aliftype.com>
Co-authored-by: خالد حسني (Khaled Hosny) <khaled@aliftype.com>
Sorry, don't know where my head was on this one (on the typing that is -- with the variable stuff I was mostly copying from other parts of the file, unsure of how reliable the cython conversion would be). |
Some test infrastructure I'm fooling with would benefit from this.
Hoping you might have some advice on whether or how I should test the x/y_variation functions, or if I should just delete those ...