chore: update lighthouse #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is failing because the best-practice score is below the budget. |
|
Thanks, I'm guessing this may have some issues but will merge anyway and try to get this shipped 🚢 |
|
Actually looks to be working pretty well! I think JITI finally solved their blocking issue with the CJS / MJS |
|
The trick is actually to add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey @harlan-zw this will update lighthouse to the current version. I already gave it a try in #167 but it did not play nice with
jitiHowever, this time it seems to work fine for me. If it does not work for you, let me know, so I can investigate further.Linked Issues
#124