-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Effective gas price #4759
base: dev
Are you sure you want to change the base?
Effective gas price #4759
Conversation
9ddc0cd
to
c6faf4c
Compare
0bb2b32
to
e3a5dd6
Compare
@Frozen During my test, effectiveGasPrice field in the transaction receipt is still not available. I checked eth_getTransactionReceipt and hmy_getTransactionReceipt Please make sure the effectiveGasPrice is the same as the gasPrice |
a230a06
to
af35364
Compare
@Frozen hmyv1 and v2 APIs has the hex vs decimal difference see below {
"transaction-hash": "0x6ce7fd454c5c3e642a4573bd684f28acaf5f5478dddf56f1ec64c8808b57190a",
"blockchain-receipt": {
"blockHash": "0xfacba8e14ccd7ae0e066df602b49251a09bccd510597fa8f5c17b0859df493f0",
"blockNumber": "0x9",
"contractAddress": "0x0000000000000000000000000000000000000000",
"cumulativeGasUsed": "0x5208",
"effectiveGasPrice": 100000000000,
"from": "one1zksj3evekayy90xt4psrz8h6j2v3hla4qwz4ur",
"gasUsed": "0x5208",
"logs": [],
"logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"root": "0x",
"shardID": 0,
"status": "0x1",
"to": "one19zzwsxr0uf2fe34y8qkadek2v0eh6h5mg2deg6",
"transactionHash": "0x6ce7fd454c5c3e642a4573bd684f28acaf5f5478dddf56f1ec64c8808b57190a",
"transactionIndex": "0x0"
},
"time-signed-utc": "2024-09-30 08:17:36.579582"
} Also eth_getTransactionReceipt still doesn't have the field {
"jsonrpc": "2.0",
"id": 1,
"result": {
"blockHash": "0xfacba8e14ccd7ae0e066df602b49251a09bccd510597fa8f5c17b0859df493f0",
"blockNumber": "0x9",
"contractAddress": null,
"cumulativeGasUsed": "0x5208",
"from": "0x15a128e599b74842bccba860311efa92991bffb5",
"gasUsed": "0x5208",
"logs": [],
"logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"status": "0x1",
"to": "0x2884e8186fe2549cc6a4382dd6e6ca63f37d5e9b",
"transactionHash": "0xad611cd8342d244e74f64888309fdf819c23f308f425edbeee289492729ae47a",
"transactionIndex": "0x0"
}
} |
af35364
to
150f2f5
Compare
Fixed json hex view for "cumulativeGasUsed": "0x5208",
"effectiveGasPrice": "0x17480", |
eth_getTransactionReceipt and the blockchain receipt generated by the hmy command during a transfer works now. Could you check hmy_getTransactionReceipt and hmyv2_getTransactionReceipt ? those would be the last ones that should require the field effectiveGasPrice |
This PR address this issue by setting the effectiveGasPrice to the transaction gas price. It is not implementing the full EIP 1559.
EffectiveGasPrice
field added to TxRusult. Added json and rlp serialization tests.