Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View change: Support for checking if validators belongs to the same key. #4802

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented Nov 14, 2024

Support for checking if validators belongs to the same key.
Leader Rotation based on getLeaderPubKey which is different for each iteration, while the view change it stays the same all time, that's why it requires additional actions for leader selection.

Based on feature IsLeaderRotationV2Epoch applies method getNextLeaderKeySkipSameAddress.

  • Quorum: removed unsed argument

@Frozen Frozen self-assigned this Nov 14, 2024
internal/params/config.go Outdated Show resolved Hide resolved
consensus/view_change.go Outdated Show resolved Hide resolved
internal/chain/engine.go Outdated Show resolved Hide resolved
@Frozen Frozen marked this pull request as ready for review November 25, 2024 18:54
@sophoah
Copy link
Contributor

sophoah commented Nov 27, 2024

@Frozen can you help rebase and fix conflict here.

@Frozen Frozen force-pushed the feature/view-change-switch-validator-by-address branch from ba7d2a5 to 37e81e1 Compare November 27, 2024 22:04
@sophoah
Copy link
Contributor

sophoah commented Dec 18, 2024

@Frozen can you rebase this one with the latest dev ?

@sophoah
Copy link
Contributor

sophoah commented Dec 20, 2024

@Frozen I tested killing the external validator node to test view change in two scenarios: make multi-bls-key and make-multi-bls-key-multi-extl-node (#4819)

Both fails to even recover from view change. Networks is basically down when view change kick off when the external leader fails to propose

for the test ps aux | grep 9008 in both scenario will give you the external leader PID to kill (kill -9 pid)

cc @mur-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants