Simplify Leader Quorum Calculations for Commit and Prepare Phases #4813
+48
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are streamsync manager code intended to be in as well ? |
No, it only moves SafeMap to common folder to be able to be used everywhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the leader quorum calculation process for the commit and prepare phases by leveraging the State structure to store the last quorum-achieved block. Previously, the quorum status was checked dynamically, which could lead to inaccuracies under certain conditions. By using a state-based approach, the process becomes more efficient and reliable, ensuring better consistency in quorum handling.