Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOG descriptor #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PHOG descriptor #4

wants to merge 2 commits into from

Conversation

lastlegion
Copy link

This adds a "PHOG" extractor to the library. PHOG is Pyramid Histogram of Oriented Gradients. These features are often used in computer vision applications.

@harthur
Copy link
Owner

harthur commented Mar 6, 2014

Sorry for the late reply. Looks like you included the whole canvas package in this.

var no_divs = options.cellSize;
options.cellSize = 1;
var phog = extractHOG(canvas, options);
for(var level = 1; level<no_levels; level++){
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't match style of rest of file. Space after "for", and before opening brace. Two-space indent. Camel case instead of underscores.

@harthur
Copy link
Owner

harthur commented Mar 10, 2014

Also looks like the image files have changed, like 'test/gradient-x.jpg', but they don't look different. See the "Files Changed".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants