New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily rewards for active nodes #1064

Open

Neeharika-Sompalli wants to merge 24 commits into hashgraph:main from Neeharika-Sompalli:hip-0000-daily-node-rewards

Member

Neeharika-Sompalli commented Oct 17, 2024

Creates a HIP for proposing daily rewards for active nodes

Neeharika-Sompalli requested a review from mgarbs as a code owner

October 17, 2024 00:54

netlify bot commented Oct 17, 2024 •

edited

Loading

✅ Deploy Preview for hedera-hips ready!

Name	Link
🔨 Latest commit	`c52d0bb`
🔍 Latest deploy log	https://app.netlify.com/sites/hedera-hips/deploys/673511e87e9dfc0008dfb22a
😎 Deploy Preview	https://deploy-preview-1064--hedera-hips.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Neeharika-Sompalli requested review from rbair23, netopyr, tinker-michaelj and Mark-Swirlds

October 17, 2024 01:14

rbair23 reviewed

View reviewed changes

HIP/hip-1064.md Outdated Show resolved Hide resolved

rbair23 reviewed

View reviewed changes

HIP/hip-1064.md Outdated Show resolved Hide resolved

rbair23 reviewed

View reviewed changes

HIP/hip-1064.md Outdated Show resolved Hide resolved

Neeharika-Sompalli force-pushed the hip-0000-daily-node-rewards branch from 1a2f249 to ca7ed2c Compare

October 17, 2024 14:56

Neeharika-Sompalli requested a review from rbair23

October 17, 2024 14:56

jsync-swirlds reviewed

View reviewed changes

Member

jsync-swirlds left a comment

Some wording improvements, a few suggestions for different arrangement, and improvements to specification protocol buffer text.

HIP/hip-1064.md Outdated Show resolved Hide resolved

HIP/hip-1064.md Show resolved Hide resolved

HIP/hip-1064.md Outdated Show resolved Hide resolved

HIP/hip-1064.md Outdated Show resolved Hide resolved

HIP/hip-1064.md Outdated Show resolved Hide resolved

HIP/hip-1064.md Outdated Show resolved Hide resolved

HIP/hip-1064.md Outdated Show resolved Hide resolved

HIP/hip-1064.md Outdated Show resolved Hide resolved

HIP/hip-1064.md Outdated Show resolved Hide resolved

HIP/hip-1064.md Outdated Show resolved Hide resolved

netopyr reviewed

View reviewed changes

HIP/hip-1064.md Outdated Show resolved Hide resolved

Neeharika-Sompalli force-pushed the hip-0000-daily-node-rewards branch from e098b2e to b9e961a Compare

October 18, 2024 16:41

Neeharika-Sompalli requested review from netopyr and jsync-swirlds

October 18, 2024 16:41

jsync-swirlds previously approved these changes

View reviewed changes

netopyr reviewed

View reviewed changes

HIP/hip-1064.md Outdated Show resolved Hide resolved

netopyr previously approved these changes

View reviewed changes

Contributor

netopyr left a comment

LGTM - thanks @Neeharika-Sompalli

Neeharika-Sompalli dismissed stale reviews from netopyr and jsync-swirlds via

fafb83f

November 7, 2024 17:09

Neeharika-Sompalli requested review from jsync-swirlds and netopyr

November 7, 2024 17:11

Neeharika-Sompalli added 7 commits

November 7, 2024 13:03


          Initial draft for daily rewards for active nodes

1b73942

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          update HIP name

a3ee264

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          update HIP number

cf69045

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          update HIP number

bdd4e70

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          update HIP number

b20a89f

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          update created date

84da99d

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          update as per review comments

d44642a

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Neeharika-Sompalli and others added 15 commits

November 7, 2024 13:03


          Change to needs-tsc-approval

7fc7325

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update HIP/hip-1064.md

81ccfe3

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update HIP/hip-1064.md

e25468f

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update HIP/hip-1064.md

082eb24

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update HIP/hip-1064.md

bc391f4

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update HIP/hip-1064.md

e1d5d6f

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update HIP/hip-1064.md

aa5aea8

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update HIP/hip-1064.md

e3ea9db

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update HIP/hip-1064.md

11217cd

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update HIP/hip-1064.md

9801f0c

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update HIP/hip-1064.md

938e20e

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          review comments

ec10c9f

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          review comments

33f9478

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          Update definition as per Leemon's suggestion

f845541

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>


          fix review comments

72146fd

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Neeharika-Sompalli force-pushed the hip-0000-daily-node-rewards branch from 8303a47 to 72146fd Compare

November 7, 2024 19:03

jsync-swirlds reviewed

View reviewed changes

Member

jsync-swirlds left a comment

A question about the added definition for judges.

HIP/hip-1064.md Show resolved Hide resolved

Neeharika-Sompalli requested a review from jsync-swirlds

November 11, 2024 14:33

tinker-michaelj approved these changes

View reviewed changes

Contributor

tinker-michaelj left a comment

LGTM, ty @Neeharika-Sompalli !

netopyr reviewed

View reviewed changes

HIP/hip-1064.md

+              - As a node operator, I expect to receive at least a minimum node reward when the node is active for at least
+                `nodes.activeRoundsPercent` rounds
+              - As a node operator, I do not expect to receive any node rewards when the node is not active for at least

Contributor

netopyr Nov 12, 2024

I understand this is following the usual pattern for use cases, but I find it weird nevertheless. How about something like:

"As a user of the network, I expect that non-active nodes do not receive any node rewards..."

Member Author

Neeharika-Sompalli Nov 12, 2024

As a user of the network

Do you mean the node operator Michael?

Contributor

netopyr Nov 13, 2024

No, I meant any regular user. It sounds weird for me to have a use case saying that somebody does not expect a certain behavior. However, as a regular user, I expect that the money I spend is only used for active nodes.

It's not important, though. It is clear what the expected behavior is.

Member

jsync-swirlds Nov 13, 2024

It might be worthwhile to have both.
The current node operator use case, and another with text very similar to what @netopyr suggested.
It's good to be clear about expectations for both node operator and network user.

Member Author

Neeharika-Sompalli Nov 13, 2024 •

edited

Loading

Ah makes sense. Thanks @netopyr . Added another use case

HIP/hip-1064.md Outdated

+              option java_package = "com.hederahashgraph.api.proto.java";
+              // <<<pbj.java_package = "com.hedera.hapi.node.state.token">>> This comment is special code for setting PBJ Compiler java package
+              option java_multiple_files = true;

Contributor

netopyr Nov 12, 2024

We should omit the header.

Member Author

Neeharika-Sompalli Nov 13, 2024

Fixed. Thanks!


          fix review comments

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Neeharika-Sompalli requested a review from netopyr

November 13, 2024 20:15


          fix review comments

c52d0bb

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tinker-michaelj tinker-michaelj approved these changes

mgarbs Awaiting requested review from mgarbs mgarbs is a code owner

Mark-Swirlds Awaiting requested review from Mark-Swirlds

rbair23 Awaiting requested review from rbair23

jsync-swirlds Awaiting requested review from jsync-swirlds

netopyr Awaiting requested review from netopyr

At least 1 approving review is required to merge this pull request.

Labels

None yet