Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize HIP 904 #1071

Closed
wants to merge 3 commits into from
Closed

Finalize HIP 904 #1071

wants to merge 3 commits into from
+3 −2

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Nov 4, 2024

Description:

  • finalize hip 904

@jnels124
* finalize hip 904
76872ce 
Signed-off-by: Jesse Nelson <jesse@hashgraph.com>
@jnels124 jnels124 self-assigned this Nov 4, 2024
@jnels124 jnels124 requested a review from mgarbs as a code owner November 4, 2024 15:10
@netlify Netlify
Copy link

netlify bot commented Nov 4, 2024 •
edited
Loading

✅ Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 504c358
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/6728ffb69798ed0008bed8cd
😎 Deploy Preview https://deploy-preview-1071--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jnels124 jnels124 changed the title * finalize hip 904 Finalize HIP 904 Nov 4, 2024
@jnels124
fix date
d8b87fc 
Signed-off-by: Jesse Nelson <jesse@hashgraph.com>
steven-sheehy
steven-sheehy reviewed Nov 4, 2024
View reviewed changes
HIP/hip-904.md Outdated Show resolved Hide resolved
@jnels124
fix version
504c358 
Signed-off-by: Jesse Nelson <jesse@hashgraph.com>
Nana-EC
Nana-EC requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HSCS section needs to be updated, it's missing details which we planned to add.
@stoyanov-st can you commit the changes in here before we merge.

Nana-EC
Nana-EC approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking, another PR will add the SC specs completion

@steven-sheehy
Copy link
Member

Closing in favor of #1080

@steven-sheehy steven-sheehy deleted the jtn-hip-904 branch November 14, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@mgarbs mgarbs Awaiting requested review from mgarbs mgarbs is a code owner

Assignees

@jnels124 jnels124

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnels124 @steven-sheehy @Nana-EC