Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monitor host metrics #9803

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix monitor host metrics #9803

merged 1 commit into from
Nov 22, 2024

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Nov 22, 2024

Description:

  • Fix node host label metric not populated with the correct endpoint
  • Change default hedera.mirror.monitor.nodeValidation.tls from PLAINTEXT to BOTH to test more endpoints by default
  • Change node supplier to round robin requests per ops request for more fair metrics with low tps and shorter time periods
  • Enable node cert verification after upstream fix

Related issue(s):

Fixes #9802

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working monitor Area: Monitoring and dashboard labels Nov 22, 2024
@steven-sheehy steven-sheehy added this to the 0.119.0 milestone Nov 22, 2024
@steven-sheehy steven-sheehy self-assigned this Nov 22, 2024
@steven-sheehy steven-sheehy requested a review from a team as a code owner November 22, 2024 20:49
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (47a9e23) to head (abfe2b4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9803   +/-   ##
=========================================
  Coverage     92.35%   92.35%           
+ Complexity     7665     7662    -3     
=========================================
  Files           932      932           
  Lines         32196    32182   -14     
  Branches       4092     4091    -1     
=========================================
- Hits          29734    29723   -11     
+ Misses         1500     1498    -2     
+ Partials        962      961    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 22, 2024

Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@jnels124 jnels124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 1f9f29e into main Nov 22, 2024
33 of 34 checks passed
@steven-sheehy steven-sheehy deleted the 9802-fix-monitor-host-metric branch November 22, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working monitor Area: Monitoring and dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor publish metrics show inaccurate node host
3 participants