Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI/CD build due to ca-certificates installation issue #436

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Fix CI/CD build due to ca-certificates installation issue #436

merged 8 commits into from
Jul 19, 2023

Conversation

rwalworth
Copy link
Contributor

@rwalworth rwalworth commented Jul 19, 2023 •
edited
Loading

Description:
This PR fixes an issue with the CI builds. It seems a version update of curl was causing the issue, this PR reverts back to the previous, working version.

Related issue(s):

Fixes #435

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth
Try older version of ca-certificates
efe9492 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth rwalworth linked an issue Jul 19, 2023 that may be closed by this pull request
Improper ca-certificate installation causing CI/CD pipeline build issues #435
Closed
@rwalworth
Add --allow-downgrades
3f17fb4 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Try upgrading?
44f3efe 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
See different available upgrade versions
02e24ad 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Try different version
671bc8b 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Downgrade again?
4673c7c 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
update curl
a08fd78 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Reset ca-certificates
80c940f 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth rwalworth self-assigned this Jul 19, 2023
@rwalworth rwalworth added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Jul 19, 2023
@rwalworth rwalworth marked this pull request as ready for review July 19, 2023 19:27
deyanzz
deyanzz approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@deyanzz deyanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rwalworth rwalworth merged commit b293440 into main Jul 19, 2023
2 checks passed
@rwalworth rwalworth deleted the 00435-improper-ca-certificate-installation-causing-cicd-pipeline-build-issues branch July 19, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyanzz deyanzz deyanzz approved these changes

@nathanklick nathanklick Awaiting requested review from nathanklick

Assignees

@rwalworth rwalworth

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improper ca-certificate installation causing CI/CD pipeline build issues
2 participants
@rwalworth @deyanzz