Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TopicMessageQuery #450

Merged
merged 50 commits into from
Aug 25, 2023
Merged

Implement TopicMessageQuery #450

merged 50 commits into from
Aug 25, 2023

Conversation

rwalworth
Copy link
Contributor

Description:
This PR implements the TopicMessageQuery, which allows users to subscribe to a topic and get its messages. It also implements the connection processing for mirror nodes.

Related issue(s):

Fixes #431

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth
Add TopicCreateTransaction
1919235 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch 'main' into 00421-implement-topiccreatetransaction
ecb3fb9
@rwalworth
Add TopicCreateTransaction unit tests
fed4f10 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicCreateTransaction integration tests | Add consensus service …
58c7c88 
…stub to Node

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicId
b7089df 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicId unit tests
be0e306 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicId to TransactionReceipt
72ae662 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch 'main' into 00421-implement-topiccreatetransaction
48d3311
@rwalworth
Merge branch 'main' into 00427-implement-topicid
99a9946
@rwalworth
Merge branch 'main' into 00421-implement-topiccreatetransaction
c01bd97
@rwalworth
Merge branch 'main' into 00427-implement-topicid
68d377f
@rwalworth
Merge branch 'main' into 00421-implement-topiccreatetransaction
19bf2de
@rwalworth
Merge branch 'main' into 00427-implement-topicid
3224370
@rwalworth
Add TopicDeleteTransaction
44a93a6 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00421-implement-topiccreatetransaction' into 00426-impl…
70ca341 
…ement-topicdeletetransaction

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicDeleteTransaction unit tests
03d0a16 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicDeleteTransaction integration tests
378d4fb 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Do TopicCreateTransaction TODOs
aaf61ee 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00427-implement-topicid' into 00428-implement-topicinfo…
9af149d 
…query
@rwalworth
Add TopicInfo and TopicInfoQuery
7350d35 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicInfo and TopicInfoQuery unit tests
13aff15 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00421-implement-topiccreatetransaction' into 00428-impl…
671f1fd 
…ement-topicinfoquery

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00426-implement-topicdeletetransaction' into 00428-impl…
ff25acf 
…ement-topicinfoquery

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicInfoQuery integration tests
926f4e3 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add to TopicCreateTransaction integration tests
1e3263a 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicUpdateTransaction
4dcef0d 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicUpdateTransaction unit tests
6af3eec 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00428-implement-topicinfoquery' into 00430-implement-to…
bf1fda3 
…picupdatetransaction

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicUpdateTransaction integration tests
44860c5 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00427-implement-topicid' into 00429-implement-topicmess…
87e0742 
…agesubmittransaction
@rwalworth
Add TopicMessageSubmitTransaction | Add createChunk() to ChunkedTrans…
0ea0709 
…action to facilitate additional functionality for derived classes when creating chunks

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicMessageSubmitTransaction unit tests
597891b 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch 'main' into 00429-implement-topicmessagesubmittransaction
c77e55f 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00430-implement-topicupdatetransaction' into 00429-impl…
9d2189f 
…ement-topicmessagesubmittransaction

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicMessageSubmitTransaction integration tests
f5e65ee 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00429-implement-topicmessagesubmittransaction' into 004…
ebd3a69 
…31-implement-topicmessagequery

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Debugging TopicMessageQuery
6d52cab 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Fix test | Remove debug statements
b9b970a 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth rwalworth added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Aug 7, 2023
@rwalworth rwalworth requested a review from deyanzz August 7, 2023 19:27
@rwalworth rwalworth self-assigned this Aug 7, 2023
@rwalworth rwalworth linked an issue Aug 7, 2023 that may be closed by this pull request
Implement TopicMessageQuery #431
Closed
@rwalworth
Use new v0.40.1 C++ protobufs to pull mirror node protos
17b0a99 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch 'main' into 00431-implement-topicmessagequery
3ec9f1e 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add 'setMirrorNetwork' function for Client
6d12fe6 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Fix linux build
d1c5d34 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@deyanzz
Copy link
Contributor

deyanzz commented Aug 9, 2023

This PR is huge and contains a lot of changes. That's why I'm still reviewing it.
Definitely, we need to fix all of the conflicts to begin with.

@rwalworth
Copy link
Contributor Author

This PR is huge and contains a lot of changes. That's why I'm still reviewing it. Definitely, we need to fix all of the conflicts to begin with.

Yeah sorry this depends on #442 and #447 so those should be reviewed and merged first.

@rwalworth
Merge branch 'main' into 00431-implement-topicmessagequery
a0cd7b2 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Copy link
Contributor Author

This is good to review again.

deyanzz
deyanzz approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@deyanzz deyanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

rwalworth and others added 7 commits August 15, 2023 16:14
@rwalworth
Increase wait time in test
b96b120 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Fix subscription issues
88a0872 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@deyanzz
Merge branch 'main' into 00431-implement-topicmessagequery
c9be30e 
# Conflicts:
#	HederaApi.cmake
@rwalworth
Adjust some chunk processing
a77a804 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Readjust processing to guarantee subscription starts before messages …
2a406e2 
…are sent to topic

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add more time for subscription to get setup and for messages to be re…
ca1f1c1 
…trieved

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Remove debug statements
0399e23 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth rwalworth merged commit 05caa8a into main Aug 25, 2023
2 checks passed
@rwalworth rwalworth deleted the 00431-implement-topicmessagequery branch August 25, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyanzz deyanzz deyanzz approved these changes

Assignees

@rwalworth rwalworth

Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TopicMessageQuery
2 participants
@rwalworth @deyanzz