Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tokenCreateTransaction): Implement JSON-RPC endpoint for TokenCreateTransaction #793

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(tokenCreateTransaction): Implement JSON-RPC endpoint for TokenCreateTransaction #793

wants to merge 5 commits into from

Conversation

rwalworth
Copy link
Contributor

Description:
This PR implements the JSON-RPC for TokenCreateTransaction (createToken).

Related issue(s):

Fixes #757

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth
feat: add createToken JSON-RPC endpoint | Fix tests to account for up…
b4ecb12 
…dated/fixed processing of fractional fees

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: check correct JSON and denominatingTokenId is a string
b6f2969 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
remove: unneeded file
71c0b3e 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth rwalworth added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Oct 10, 2024
@rwalworth rwalworth self-assigned this Oct 10, 2024
@rwalworth rwalworth requested review from a team as code owners October 10, 2024 14:08
@rwalworth rwalworth linked an issue Oct 10, 2024 that may be closed by this pull request
TCK-C++: Implement JSON-RPC methods for TokenCreateTransaction #757
Open
@rwalworth rwalworth mentioned this pull request Oct 10, 2024
Open
2 tasks
gsstoykov
gsstoykov previously approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rwalworth
fix: update for changes to tokencreate tck
9b72d82 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: add include for std::invalid_argument
ef428e9 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsstoykov gsstoykov gsstoykov left review comments

@agadzhalov agadzhalov Awaiting requested review from agadzhalov agadzhalov is a code owner automatically assigned from hashgraph/hedera-sdk-cpp-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

@rwalworth rwalworth

Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TCK-C++: Implement JSON-RPC methods for TokenCreateTransaction
2 participants
@rwalworth @gsstoykov