Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

104 no pass though #105

Merged
merged 4 commits into from
Oct 12, 2023
Merged

104 no pass though #105

merged 4 commits into from
Oct 12, 2023

Conversation

jasperpotts
Copy link
Member

Fix for leaking reference into read Bytes object, it must be a copy to be safe because Bytes is expected to be immutable.

Also fixed toString hex printing.

jasperpotts and others added 3 commits October 11, 2023 17:15
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
Signed-off-by: Richard Bair <rbair23@users.noreply.github.com>
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
rbair23
rbair23 previously approved these changes Oct 12, 2023
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

JUnit Test Report

     37 files       37 suites   1m 4s ⏱️
   491 tests    490 ✔️ 1 💤 0
2 679 runs  2 670 ✔️ 9 💤 0

Results for commit e25eaaa.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Integration Test Report

86 721 tests   86 721 ✔️  3m 10s ⏱️
     209 suites           0 💤
     209 files             0

Results for commit e25eaaa.

♻️ This comment has been updated with latest results.

Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
@rbair23 rbair23 merged commit 5950521 into main Oct 12, 2023
6 checks passed
@rbair23 rbair23 deleted the 104-no-pass-though branch October 12, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants