-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 284: writeByte() may be improved for byte array based BufferedData #285
Conversation
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
JUnit Test Report 55 files ±0 55 suites ±0 2m 10s ⏱️ -8s Results for commit 80b5b22. ± Comparison against base commit 223a232. This pull request removes 8 and adds 7 tests. Note that renamed tests count towards both.
|
Integration Test Report 289 files ±0 289 suites ±0 9m 54s ⏱️ + 2m 46s Results for commit 80b5b22. ± Comparison against base commit 223a232. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
|
Fix summary:
writeByte2()
,writeByte3()
, andwriteByte4()
methods toWritableSequentialData
writeByte()
the right number of timesByteArrayBufferedData
the methods are implemented more efficiently than N calls towriteByte()
Performance:
ProtobufObjectBench
, writingEverything
to byte array output is about 12% faster than previouslyFixes: #284
Signed-off-by: Artem Ananev artem.ananev@swirldslabs.com