Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for testing with metrics #327

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

rbair23
Copy link
Member

@rbair23 rbair23 commented Nov 15, 2024

Adds a new dependency when testing, so as to have a real implementation of metrics.

Signed-off-by: Richard Bair <rbair23@users.noreply.github.com>
@rbair23 rbair23 requested review from a team as code owners November 15, 2024 23:03
@rbair23 rbair23 linked an issue Nov 15, 2024 that may be closed by this pull request
Copy link

JUnit Test Report

   67 files  ±0     67 suites  ±0   2m 32s ⏱️ -1s
1 247 tests ±0  1 242 ✅  - 2   5 💤 +2  0 ❌ ±0 
7 102 runs  ±0  7 081 ✅  - 2  21 💤 +2  0 ❌ ±0 

Results for commit 658ea2e. ± Comparison against base commit d7c41ea.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.
, 1
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
, 1
This pull request skips 2 tests.
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [2] text/plain
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [3] application/json

Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Integration Test Report

    297 files  ±0      297 suites  ±0   9m 3s ⏱️ ±0s
104 157 tests ±0  104 157 ✅ ±0  0 💤 ±0  0 ❌ ±0 
104 385 runs  ±0  104 385 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 658ea2e. ± Comparison against base commit d7c41ea.

@rbair23 rbair23 merged commit e6a8c9b into main Nov 15, 2024
10 checks passed
@rbair23 rbair23 deleted the 00326-add-support-for-testing-metrics branch November 15, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for testing metrics
2 participants