Added patch from Jasper. Addressed Jasper's comments. Changed generat…
39 new issues (0 max.) of at least minor severity.
Issues
======
+ Solved 28
- Added 39
Coverage decreased per file
===========================
- pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java -14.868
Complexity increasing per file
==============================
- pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ComplexEqualsHashCodeBench.java 2
- pbj-integration-tests/src/test/java/com/hedera/pbj/intergration/test/HashEqualsTest.java 1
- pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/HashBench.java 2
- pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/EqualsHashCodeBench.java 2
- pbj-integration-tests/src/test/java/com/hedera/pbj/intergration/test/TestHashFunctions.java 23
Clones added
============
- pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/json/JsonCodecParseMethodGenerator.java 2
Clones removed
==============
+ pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/protobuf/CodecParseMethodGenerator.java -2
See the complete overview on Codacy
Annotations
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L272
Avoid throwing raw exception types.
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L272
Line is longer than 120 characters (found 138).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L288
Avoid reassigning parameters such as 'generatedCodeSoFar'
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L330
Line is longer than 120 characters (found 129).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L368
Avoid reassigning parameters such as 'generatedCodeSoFar'
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L368
Line is longer than 120 characters (found 121).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L407
Must have at least one statement.
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L437
Line is longer than 120 characters (found 146).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/EnumGenerator.java#L193
Line is longer than 120 characters (found 148).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/EnumGenerator.java#L199
Line is longer than 120 characters (found 125).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java#L40
File contains tab characters (this is the first instance).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java#L284
Line is longer than 120 characters (found 124).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java#L490
Line is longer than 120 characters (found 131).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/TestGenerator.java#L142
Line is longer than 120 characters (found 200).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/json/JsonCodecParseMethodGenerator.java#L99
Line is longer than 80 characters (found 127).
codacy-production / Codacy Static Code Analysis
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/protobuf/CodecParseMethodGenerator.java#L53
Line is longer than 120 characters (found 136).
codacy-production / Codacy Static Code Analysis
pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ComplexEqualsHashCodeBench.java#L64
'VARIABLE_DEF' should be separated from previous line.
codacy-production / Codacy Static Code Analysis
pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ComplexEqualsHashCodeBench.java#L67
'VARIABLE_DEF' should be separated from previous line.
codacy-production / Codacy Static Code Analysis
pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ComplexEqualsHashCodeBench.java#L68
'VARIABLE_DEF' should be separated from previous line.
codacy-production / Codacy Static Code Analysis
pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/EqualsHashCodeBench.java#L45
'VARIABLE_DEF' should be separated from previous line.
codacy-production / Codacy Static Code Analysis
pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/EqualsHashCodeBench.java#L46
'VARIABLE_DEF' should be separated from previous line.
codacy-production / Codacy Static Code Analysis
pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/EqualsHashCodeBench.java#L47
'VARIABLE_DEF' should be separated from previous line.
codacy-production / Codacy Static Code Analysis
pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/EqualsHashCodeBench.java#L82
'METHOD_DEF' should be separated from previous line.
codacy-production / Codacy Static Code Analysis
pbj-integration-tests/src/test/java/com/hedera/pbj/intergration/test/TestHashFunctions.java#L21
Avoid throwing raw exception types.
codacy-production / Codacy Static Code Analysis
pbj-integration-tests/src/test/java/com/hedera/pbj/intergration/test/TestHashFunctions.java#L91
Avoid reassigning parameters such as 'val'