config: allow setting security_opt option
#382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ruspaul013
force-pushed
the
security-opt
branch
from
bc3f877 to
6a7bf35
Compare
shoenig
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Sorry for taking so long to reviewing this @ruspaul013, but it looks good!
|
@shoenig no worries, thank you Later edit: I saw that test are failing because I used |
|
@ruspaul013 Oh yeah that'd be good to fix if you don't mind creating the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support --security-opt option as was mention in #297.