Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-32188: Enos test for PKI certificates #29007

Open
wants to merge 54 commits into
base: main
Choose a base branch
from

Conversation

tvo0813
Copy link
Collaborator

@tvo0813 tvo0813 commented Nov 23, 2024

Description

VAULT-32188: Create Enos test for PKI issuing and signing certificates

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@tvo0813 tvo0813 requested a review from a team as a code owner November 23, 2024 00:54
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 23, 2024
Copy link

github-actions bot commented Nov 23, 2024

CI Results:
All required Go tests succeeded but failures were detected ⚠️
Failures:

Test Type Package Test Logs
race vault/external_tests/raft TestSysHealth_Raft view test results
race vault/external_tests/raft TestSysHealth_Raft/remove_and_unpartition view test results

Copy link

github-actions bot commented Nov 23, 2024

Build Results:
All builds succeeded! ✅

@tvo0813 tvo0813 added pr/no-changelog pr/no-milestone backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x labels Nov 23, 2024
@tvo0813 tvo0813 force-pushed the enos/VAULT-32188_pki_certificates branch from d275880 to fd34473 Compare December 3, 2024 22:13
Copy link
Collaborator

@ryancragun ryancragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot dang! Good job on your fist scenario expansion. Things are looking good!

It looks like we're missing updates to steps that are implemented by the vault_verify_secrets_engines_read module in a few scenarios:

  • Autopilot
  • DR Replication
  • PR Replication
  • Seal HA

We'll need to get those updates with the vault_root_token variable. It would be nice to create a test branch in vault-enterprise with all the changes to verify these changes so that when the CE -> Ent merge happens that there won't be any surprises.

While I didn't restate the feedback, the feedback on the read/pki module also applies to the create/pki module.

@tvo0813 tvo0813 force-pushed the enos/VAULT-32188_pki_certificates branch from 02fa4e9 to 258b800 Compare December 19, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants