Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update the page description for SEO improvement #2 #29116

Merged
merged 13 commits into from
Dec 18, 2024

Conversation

yhyakuna
Copy link
Contributor

@yhyakuna yhyakuna commented Dec 6, 2024

Description

This PR updates the secrets engine docs title & description for style consistency, as well as SEO improvement.

  • secrets/transit/index.mdx
  • secrets/transit/key-wrapping-guide.mdx
  • secrets/transit/key-wrapping-guide.mdx
  • secrets/transform/index.mdx
  • secrets/transform/ff3-tweak-details.mdx
  • secrets/transform/tokenization.mdx
  • secrets/ssh/index.mdx
  • secrets/ssh/one-time-ssh-passwords.mdx
  • secrets/ssh/signed-ssh-certificates.mdx

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@yhyakuna yhyakuna requested a review from a team December 6, 2024 06:58
@yhyakuna yhyakuna self-assigned this Dec 6, 2024
@yhyakuna yhyakuna requested a review from a team as a code owner December 6, 2024 06:58
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Dec 6, 2024

Build Results:
All builds succeeded! ✅

Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>
@yhyakuna
Copy link
Contributor Author

yhyakuna commented Dec 9, 2024

@sgmiller I believe I addressed all your concerns. Please review. 🙏

@yhyakuna yhyakuna merged commit 8aa6fa3 into main Dec 18, 2024
33 of 34 checks passed
@yhyakuna yhyakuna deleted the docs/secrets-seo-updates-2 branch December 18, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants