Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-33008: Enos tests for removed raft nodes #29214

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

miagilepner
Copy link
Contributor

@miagilepner miagilepner commented Dec 17, 2024

Description

This PR adds enos verifications in the smoke and autopilot scenarios.

The smoke scenario now removes a raft node, then checks that it's removed and can't be added back or unsealed. Finally, the data is deleted from the node and then it verifies that it's sucesfully added back.

The autopilot scenario already had nodes being removed from the raft cluster. Now, the scenario will verify that the nodes report themselves as removed and that they can't be added back or unsealed. You can check out at commit 5e35bca to see how I ran the autopilot scenario locally to test that it works.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@miagilepner miagilepner added this to the 1.19.0-rc milestone Dec 17, 2024
@miagilepner miagilepner requested a review from a team as a code owner December 17, 2024 17:19
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Dec 17, 2024

Build Results:
Build failed for these jobs: test:failure. Please refer to this workflow to learn more: https://github.com/hashicorp/vault/actions/runs/12392716355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant