[VAULT-33146] Update tutorial link for creating a policy

[beagins]

Description

What does this PR do?
Update tutorial link for creating a policy.

Had to get a little hacky and comment out an if/else conditional in order to display empty state w/ link (default state is not empty, & unable to delete/remove default policy, so not sure when empty state is actually rendered):

"Getting started with policies" link points to new url:

TODO only if you're a HashiCorp employee

• Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
  • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
• ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
  of a public function, even if that change is in a CE file, double check that
  applying the patch for this PR to the ENT repo and running tests doesn't
  break any tests. Sometimes ENT only tests rely on public functions in CE
  files.
• Jira: If this change has an associated Jira, it's referenced either
  in the PR description, commit message, or branch name.
• RFC: If this change has an associated RFC, please link it in the description.
• ENT PR: If this change has an associated ENT PR, please link it in the
  description. Also, make sure the changelog is in this PR, not in your ENT PR.

[hashicorp-cla-app]

All committers have signed the CLA.

[hashicorp-cla-app]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[github-actions]

CI Results:
All Go tests succeeded! ✅

[github-actions]

Build Results:
All builds succeeded! ✅

[anwittin]

looks good

[hellobontempo]

Woah, you even included a changelog! 🤩 PRs like this don't necessarily need a changelog since it's a pretty small change. Always feel free to ask, but when I'm deciding whether or not to include one I usually ask myself: "Is this a change that will be helpful to surface to the user?"

It is good to make changelogs specific so I'd suggest mentioning that this was specifically for a policy tutorial link if you do decide to keep the changelog 😄 Something like:
Update tutorial link for creating a policy

[beagins]

Ah okay cool! tbh I didn't realize the changelog was optional 😅 I saw the ❌ on the ci pipeline and added it lol
I'll go ahead and update the changelog comment to be more specific, thanks @hellobontempo !!

[hellobontempo]

Ah I see! You can add the lable pr/no-changelog to skip the changelog check but it doesn't block the merge 😄

[hellobontempo]

If this is going to be backported, I recommend adding the backport/1.18.x label and this will automatically open a backport PR! Feel free to DM me if you want to review backporting 😄

Also, we should update the milestone to 1.18.4

[beagins]

Ran yarn test:ent against latest vault-enterprise server:

1..202
# tests 202
# pass  192
# skip  10
# todo  0
# fail  0

# ok

[hellobontempo]

Great work! Same note about the changelog, I think it'd be useful for the PR description and title to mention that it's specifically a policy tutorial link. (Most all of our PRs will be Vault related 😄 )

Also, screenshots can be useful to include in the description for posterity since it's not always immediately clear where the link renders.

Congrats on your first PR!! 🎉 🎉 🎉