Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.18.x UI: Update PostgreSQL database params (#29200) #29231

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

hellobontempo
Copy link
Contributor

Manual backport #29200

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

* add testing before model changes

* add enterprise self_managed attr, update tests

* add postgres params

* add changelog

* update test

* cleanup filter function

* fix nits
@hellobontempo hellobontempo added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Dec 18, 2024
@hellobontempo hellobontempo added this to the 1.18.3 milestone Dec 18, 2024
@hellobontempo hellobontempo requested a review from a team as a code owner December 18, 2024 22:43
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 18, 2024
Copy link

Build Results:
All builds succeeded! ✅

Monkeychip
Monkeychip previously approved these changes Dec 18, 2024
@hellobontempo hellobontempo enabled auto-merge (squash) December 18, 2024 23:35
@hellobontempo hellobontempo changed the title UI: Update PostgreSQL database params (#29200) Backport 1.18.x UI: Update PostgreSQL database params (#29200) Dec 18, 2024
@anwittin anwittin modified the milestones: 1.18.3, 1.18.4 Dec 18, 2024
Copy link

github-actions bot commented Dec 19, 2024

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo merged commit 428e297 into release/1.18.x Dec 19, 2024
24 checks passed
@hellobontempo hellobontempo deleted the backport-1.18.x-update-db-params branch December 19, 2024 20:12
@hellobontempo hellobontempo removed backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants