-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass full request path to the post auth webhook, maybe fix #8771 #10049
base: master
Are you sure you want to change the base?
pass full request path to the post auth webhook, maybe fix #8771 #10049
Conversation
Beep boop! 🤖 Hey @axe-me, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
|
Hello! Thanks for your contribution! It sounds like you haven't managed to build Once it's set up you should be able to run a local HGE instance using Let me know if you have any trouble getting everything working. |
Hi @danieljharvey , thanks for check this. I just spent a few hours setting up the local dev, but none of the approaches works for me on my MacBook, the nix approach runs for few hours but still not finished (even with the caches), hopefully the new vite based setup could improve the DX a bit. |
Hey! Sorry to hear that - there are some more specific MacOS instructions here that might be helpful? https://github.com/hasura/graphql-engine/blob/master/server/COMPILING-ON-MACOS.md |
I read this doc and followed the instructions, it works and compiles, just extremely slow. |
Description
Pass the full request path to the auth webhook in the AHPost handler
Changelog
Component : server
Type: enhancement
Product: community-edition
Short Changelog
Pass the full request path to the auth webhook in the AHPost handler
Long Changelog
Related Issues
#8771
Solution and Design
TBH I'm not sure if my solution works, I simply create a new data type and create a variable with the full request path which is the path + query params, and then pass the variable to the getInfo function, don't know if this gonna break the type checking in haskell.
I only learned a bit haskell today and put up the PR with chatgpt. Please let me know if this totally wont work and how can I make it work. Really appreciated it, my company needs to use this feature to do some callback webhook secret from query params validation.
Steps to test and verify
Send a api/rest request to the engine, then full path should be included in the request body of the request sending to auth hook.
Limitations, known bugs & workarounds
n/a
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
run_sql
auto manages the new metadata through schema diffing?run_sql
auto manages the definitions of metadata on renaming?export_metadata
/replace_metadata
supports the new metadata added?GraphQL
Breaking changes
No Breaking changes
There are breaking changes:
Metadata API
Existing
query
types:args
payload which is not backward compatibleJSON
schemaGraphQL API
Schema Generation:
NamedType
Schema Resolve:-
null
value for any input fieldsLogging
JSON
schema has changedtype
names have changed