Update ndc-models and ndc-sdk to v0.1.4 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmoverton
changed the title
hallettj
approved these changes
Jun 13, 2024
Comment on lines
+140
to
+149
| ndc::Aggregate::ColumnCount { | ||
| column, | ||
| distinct, | ||
| field_path: _, | ||
| } => Ok(plan::Aggregate::ColumnCount { column, distinct }), | ||
| ndc::Aggregate::SingleColumn { | ||
| column, | ||
| function, | ||
| field_path: _, | ||
| } => { |
There was a problem hiding this comment.
We want to forward field paths here. But we need to do a pass of testing and cleaning up aggregate support anyway so that can wait a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update to NDC v0.1.4 and path through
file_pathproperties for filtering and ordering.Type
(Select only one. In case of multiple, choose the most appropriate)