Merge pull request #21 from mschout/bugfix/fix-scope-set-extras

Fix set_extras so that it does not crash
heiseonline · Nov 21, 2023 · d7f5b11 · d7f5b11
2 parents f44b11f + 3573c51
commit d7f5b11
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/Sentry/Hub/Scope.pm b/lib/Sentry/Hub/Scope.pm
@@ -34,7 +34,9 @@ sub set_extra ($self, $name, $value) {
 }
 
 sub set_extras ($self, $extras) {
-  $self->extra = { %{ $self->extra }, %{$extras} };
+  for my $key (%$extras) {
+    $self->extra->{$key} = $extras->{$key};
+  }
 }
 
 sub set_tag ($self, $key, $value) {

diff --git a/t/scope.t b/t/scope.t
@@ -12,6 +12,7 @@ use Sentry::Hub::Scope;
 use Sentry::Severity;
 use Sentry::Tracing::Span;
 use Sentry::Tracing::Transaction;
+use Test::Exception;
 use Test::Spec;
 
 describe 'Sentry::Hub::Scope' => sub {
@@ -81,6 +82,12 @@ describe 'Sentry::Hub::Scope' => sub {
       is $event->{foo}, 'bar';
     };
   };
+
+  describe 'set_extras' => sub {
+    it 'set_extras should not crash' => sub {
+      lives_ok { Sentry::Hub::Scope->new->set_extras({ foo => 'bar' }) };
+    };
+  };
 };
 
 runtests;