Add cargo feature that enables piping on macos #7607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think a feature is the right way to handle this. On macos we likely never want to turn this off and requiring an extra argument to build on macos will be missed by many. Since resolver version 2 you can use a target specific dependency to handle this: [target.'cfg(target_os = "macos")'.dependencies]
crossterm = { version = "0.26", features = ["use-dev-tty"] } |
pascalkuthe
added
O-macos
|
@pascalkuthe totally missed that this was possible! will add this in a jiffy |
|
Pushed to the original PR #5468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5468.
Since there have been understandable performance concerns around the tty polling implementation in the
crosstermfeature that enables piping on macos (crossterm-rs/crossterm#735), this PR adds a feature flag to selectively enable this, so that we can conditionally compile it only for macos targets.