-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: windows support #42
feat: windows support #42
Conversation
I noticed that page_allocator is used extensively in the overall code. This memory allocator will directly allocate the entire page, and its speed is slower. Now I created a new file called |
And I adjusted the build mode in |
I also found that the use of |
But it seems that they are all executed successfully, and further investigation may be needed. |
remove tmpfile
Oh, I see that most of the situations above have been mentioned by you in other issues |
Yeah, if there is something not yet covered feel free to open up an issue.
For not getting this PR too big. You can open up a pull request for these improvements or like i mentioned open up an issue. IIRC github action runner are using "windows-server" which it is not the same as enterprise windows. Had some trouble because of that in other projects. For the first integration that could be fine, but maybe using something like this https://hub.docker.com/_/microsoft-windows-base-os-images could be better. Overall looking great, really appreciate your contribution. Ping me if you think it should be reviewed. |
Then if you think there is no problem, I have done some tests and it seems that we can temporarily merge the PR. |
Regarding other issues, I will open a new PR separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Great work.
Co-authored-by: hndrk <51416554+hendriknielaender@users.noreply.github.com>
format code
The current code can only be said to work, after the PR is merged, I will reorganize the code logic, including fixes for issues that have been raised |
Later we can try to apply for administrator rights when needed. The speed of copying files on the Windows platform is really not ideal. |
This PR is used to add windows support, but do not merge it yet.
The PR still needs more testing