-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add zls support #58
Conversation
…s a hash, try to verify it directly.
Sorry, I made a lot of changes to the source code, but I think the changes were worth it and the readability should be improved by now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort on the recent updates! The improvements are appreciated. It's exciting to see that we'll soon support zls as well, which will significantly enhance zvm. Keep up the excellent work!
… functions into `util`
Yes, actually I recommend not using |
There is no problem when testing under Linux. I have not tested on Windows. |
Alright, I will test it for Windows and macOS |
If the tests are OK, I think it can be merged, but it should not be released immediately because the interaction is broken. I will try to add local compilation support for zzls and master update support for zig and zls later |
Hey man, I don't know if you are willing to accept this PR now, If you are not willing to accept the PR, you can close it |
I'm willing to accept this, but the minimum requirement for me would be that this is tested on windows as well. Last week I didn't had time to verify your changes, feel free to manual test this. |
now, windows test ok Due to the introduction of new code, macos and linux platforms need to be retested |
I will try linux testing later |
Linux tests OK. |
Features
remove
Since the original download information is destroyed, it is not clear what kind of interaction should be better.