Skip to content

Commit

Permalink
Remove deprecated CreateDefaultNetwork function (#1557)
Browse files Browse the repository at this point in the history
It was unused already

Relates-To: OCMAM-212

Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
  • Loading branch information
andrey-kashcheev authored Oct 16, 2024
1 parent bb6e941 commit 4dbffdf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
9 changes: 1 addition & 8 deletions olp-cpp-sdk-core/include/olp/core/http/Network.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2023 HERE Europe B.V.
* Copyright (C) 2019-2024 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -147,13 +147,6 @@ class CORE_API Network {
virtual Statistics GetStatistics(uint8_t bucket_id = 0);
};

/// Creates a default `Network` implementation.
OLP_SDK_DEPRECATED(
"Will be removed by 05.2024, use "
"CreateDefaultNetwork(NetworkInitializationSettings) instead")
CORE_API std::shared_ptr<Network> CreateDefaultNetwork(
size_t max_requests_count);

/// Creates a default `Network` implementation.
CORE_API std::shared_ptr<Network> CreateDefaultNetwork(
NetworkInitializationSettings settings);
Expand Down
6 changes: 0 additions & 6 deletions olp-cpp-sdk-core/src/http/Network.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,6 @@ Network::Statistics Network::GetStatistics(uint8_t /*bucket_id*/) {
return Network::Statistics{};
}

std::shared_ptr<Network> CreateDefaultNetwork(size_t max_requests_count) {
NetworkInitializationSettings settings;
settings.max_requests_count = max_requests_count;
return CreateDefaultNetwork(std::move(settings));
}

std::shared_ptr<Network> CreateDefaultNetwork(
NetworkInitializationSettings settings) {
auto network = CreateDefaultNetworkImpl(std::move(settings));
Expand Down

0 comments on commit 4dbffdf

Please sign in to comment.