Use custom token endpoint url from AuthenticationCredentials #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykolamalik
force-pushed
the
bug/olpedge-2834
branch
2 times, most recently
from
1eec01f to
988ed3e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1433 +/- ##
==========================================
- Coverage 79.96% 79.95% -0.00%
==========================================
Files 339 339
Lines 13042 13044 +2
Branches 1415 1415
==========================================
+ Hits 10428 10429 +1
Misses 2042 2042
- Partials 572 573 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mykolamalik
requested review from
Smartkras,
mykhailo-kuchma,
andrey-kashcheev and
rustam-gamidov-here
olp-cpp-sdk-authentication/include/olp/authentication/Settings.h
Outdated
Show resolved
Hide resolved
The token provider read from a credentials file in the method `AuthenticationCredentials::ReadFromStream()` was not used for the authentication request. Relates-To: OLPEDGE-2834 Signed-off-by: Mykola Malik <ext-mykola.malik@here.com>
mykolamalik
force-pushed
the
bug/olpedge-2834
branch
from
988ed3e to
998bfa7
Compare
|
Gitlab-bot - Internal E2E verification pipeline FAILED! |
Smartkras
approved these changes
Sep 19, 2023
mykhailo-kuchma
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token provider read from a credentials file in the method
AuthenticationCredentials::ReadFromStream()was not used for the authentication request.Relates-To: OLPEDGE-2834