Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Win build job #1500

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add Win build job #1500

merged 1 commit into from
Nov 15, 2024

Conversation

ystefinko
Copy link
Collaborator

@ystefinko ystefinko commented Apr 22, 2024

Add Win build job to have minimal verification on
Windows. Use the image with VC 2019.
Minor updates in jobs to remove temporary tips.

Relates-To: OLPEDGE-2873, DATASDK-53

@ystefinko ystefinko force-pushed the olpedge-28730-win-ci branch 13 times, most recently from b336a11 to 798b2fc Compare April 22, 2024 12:13
@ystefinko ystefinko force-pushed the olpedge-28730-win-ci branch 16 times, most recently from ee4eb59 to 1e3be51 Compare April 24, 2024 10:15
@ystefinko ystefinko force-pushed the olpedge-28730-win-ci branch 6 times, most recently from eb5583e to b19c7f5 Compare April 25, 2024 12:06
@ystefinko ystefinko changed the title Add Win build job Draft: Add Win build job Jun 20, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.41%. Comparing base (0cd2288) to head (0dda4c2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
+ Coverage   81.37%   81.41%   +0.04%     
==========================================
  Files         345      345              
  Lines       13521    13522       +1     
  Branches     1459     1460       +1     
==========================================
+ Hits        11002    11008       +6     
+ Misses       1922     1920       -2     
+ Partials      597      594       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ystefinko ystefinko force-pushed the olpedge-28730-win-ci branch 2 times, most recently from c032fa8 to ca82729 Compare September 2, 2024 09:42
@ystefinko ystefinko changed the title Draft: Add Win build job Add Win build job Sep 13, 2024
Validation on windows runner:
windows-2019 using type: RelWithDebInfo
and GENERATOR: "Visual Studio 16 2019"

Relates-To: MINOR

Signed-off-by: Yaroslav Stefinko <ext-yaroslav.stefinko@here.com>
@ystefinko ystefinko merged commit de37609 into master Nov 15, 2024
25 checks passed
@ystefinko ystefinko deleted the olpedge-28730-win-ci branch November 15, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants