Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated NetworkSettings functions #1556

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

andrey-kashcheev
Copy link
Collaborator

Deprecated ones were used only in tests

Relates-To: OCMAM-212

Deprecated ones were used only in tests

Relates-To: OCMAM-212

Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (8e6a6c9) to head (e53cfeb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage   81.34%   81.35%   +0.01%     
==========================================
  Files         345      345              
  Lines       13541    13525      -16     
  Branches     1459     1459              
==========================================
- Hits        11014    11003      -11     
+ Misses       1931     1928       -3     
+ Partials      596      594       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-kashcheev andrey-kashcheev merged commit bb6e941 into master Oct 15, 2024
21 checks passed
@andrey-kashcheev andrey-kashcheev deleted the ocmam-212-deprecated-network-settings branch October 15, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants