Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made deprecated HttpResponse fields private #1558

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

andrey-kashcheev
Copy link
Collaborator

Methods should be used instead

Relates-To: OCMAM-212

@andrey-kashcheev andrey-kashcheev force-pushed the ocmam-212-deprecated-http-response branch from 490df93 to e8c147c Compare October 16, 2024 15:20
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 69.85646% with 63 lines in your changes missing coverage. Please review.

Project coverage is 81.41%. Comparing base (4dbffdf) to head (b3b2833).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...pp-sdk-dataservice-write/src/generated/BlobApi.cpp 25.00% 9 Missing ⚠️
...dk-dataservice-write/src/generated/MetadataApi.cpp 0.00% 9 Missing ⚠️
...sdk-dataservice-write/src/generated/PublishApi.cpp 61.90% 8 Missing ⚠️
...p-sdk-dataservice-write/src/generated/IndexApi.cpp 0.00% 4 Missing and 2 partials ⚠️
...-sdk-dataservice-write/src/generated/IngestApi.cpp 44.44% 4 Missing and 1 partial ⚠️
...p-sdk-dataservice-write/src/generated/QueryApi.cpp 16.67% 4 Missing and 1 partial ⚠️
...dataservice-read/src/generated/api/MetadataApi.cpp 80.00% 3 Missing ⚠️
...dataservice-read/src/generated/api/PlatformApi.cpp 0.00% 3 Missing ⚠️
...-sdk-dataservice-write/src/generated/ConfigApi.cpp 50.00% 3 Missing ⚠️
...dk-dataservice-write/src/generated/PlatformApi.cpp 50.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1558      +/-   ##
==========================================
+ Coverage   81.37%   81.41%   +0.04%     
==========================================
  Files         345      345              
  Lines       13525    13532       +7     
  Branches     1458     1459       +1     
==========================================
+ Hits        11005    11016      +11     
+ Misses       1926     1923       -3     
+ Partials      594      593       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

olp-cpp-sdk-dataservice-write/src/generated/PublishApi.cpp Outdated Show resolved Hide resolved
olp-cpp-sdk-core/src/client/RetrySettings.cpp Outdated Show resolved Hide resolved
Methods should be used instead

Relates-To: OCMAM-212

Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
@andrey-kashcheev andrey-kashcheev merged commit 4f07bae into master Oct 17, 2024
20 of 21 checks passed
@andrey-kashcheev andrey-kashcheev deleted the ocmam-212-deprecated-http-response branch October 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants