OLPHttpTask to lock toIgnoreResponse before usage #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is 'synchronized' in the didCompleteWithError callback so it's better to add 'synchronized' in the restarting as well Relates-To: DATASDK-45 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
force-pushed
the
rga/syncronize-restart
branch
from
ca690b1 to
fff57fd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
+ Coverage 81.39% 81.39% +0.01%
==========================================
Files 345 345
Lines 13512 13511 -1
Branches 1458 1458
==========================================
Hits 10997 10997
- Misses 1919 1920 +1
+ Partials 596 594 -2 ☔ View full report in Codecov by Sentry. |
andrey-kashcheev
approved these changes
Oct 24, 2024
mykolamalik
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is 'synchronized' in the didCompleteWithError callback so it's better to add 'synchronized' in the restarting as well
Relates-To: DATASDK-45