Ensure fields to be consistent after editing #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
minff
commented
Jul 21, 2021
•
minff
commented
- Ensure xyz_id uniqueness via sqlite trigger instead of 'on replace conflict' constraint
- Ensure fields to be consistent with provider fields to avoid data corruption, especially after editing
- map_fields, feat.fields
- Ensure the paired order of fields-vector layer after a layer is removed (set fields to empty for deleted layer)
- Handle virtual fields (expression field) in data loading
- virtual fields shall never be appended to provider fields, it only stays as vector layer fields
- related to Problem continuing loading data in layer with Virtual Field #38
- Update test for parser and render
- Disconnect signal silently to avoid exception
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
+ selecting order: * score >= threshold * score == -1 (empty fields) * score < threshold (create new fields) + applied to case: deleted layer reset QgsFields to empty Signed-off-by: minff <16268924+minff@users.noreply.github.com>
+ filter virtual field out of fields may cause feature attributes order to corrupt + provider_fields is assumed to be equals to new_fields (=old provider_fields + diff_fields) + TODO: update fields of feature from new_fields to merged provider_fields if previous assumption not met Signed-off-by: minff <16268924+minff@users.noreply.github.com>
…specially after creating features Signed-off-by: minff <16268924+minff@users.noreply.github.com>
+ avoid data corruption due to misaligned fields order Signed-off-by: minff <16268924+minff@users.noreply.github.com>
+ on conflict replace does not work after create/delete column in edit mode (commit error) Signed-off-by: minff <16268924+minff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.