Update resolve_version to support both inventory formats #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlarraz
force-pushed
the
resolve_version
branch
from
9cb49eb to
921f9af
Compare
mlarraz
force-pushed
the
resolve_version
branch
from
921f9af to
913582e
Compare
|
Updated to incorporate changes from #926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step at addressing #938
This preserves the existing script's behavior while also allowing it to read the newer Inventory format from
heroku_inventory_utilsas used in https://github.com/heroku/buildpacks-nodejs/blob/main/buildpacks/nodejs-engine/src/main.rs.I also added a more detailed error message for when no resolution is found, listing the requirements as well as target OS and arch.