refactor: better usage of fragment_cache #152
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After have a close look at hexojs/hexo#2164, I have realized something.
Although configuration file (both site's
_config.yml
and theme's_config.yml
) is loaded only once, but the value has to be readed from parsed config (inside Locals) every time when meets in layout. So it is important to wrap config value inside fragment_cache.I have ran through a benchmark with same setup I used in hexojs/hexo#3663. Before c8d5d16, is takes about 6.16 seconds to generate a site with 300 posts, After c8d5d16, it drops to about 5.9 seconds, which is about 4% less.
This PR is a PoC that we should wrap
<%= config.xxx %>
or<%= theme.xxx %>
inside fragment_cache as much as possible.