Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enhance_cache): bring up [locals] #3902

Closed
wants to merge 2 commits into from

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Dec 2, 2019

What does it do?

This PR is a part of #3897. When enhance_cache is enabled, partial will enable fragment_cache result unless theme developer specific { cache: false } or the locals has changed.

How to test

git clone -b feat_enhance_cache https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Dec 2, 2019

Coverage Status

Coverage increased (+0.004%) to 97.139% when pulling 38175d6 on SukkaW:feat_enhance_cache into e423773 on hexojs:master.

@SukkaW SukkaW changed the title feat(enhance cache): bring up feat(enhance_cache): bring up Dec 2, 2019
@SukkaW SukkaW requested review from curbengh, segayuu, NoahDragon and a team and removed request for curbengh and NoahDragon December 2, 2019 14:14
@SukkaW SukkaW changed the title feat(enhance_cache): bring up [WIP] feat(enhance_cache): bring up Dec 2, 2019
@SukkaW SukkaW removed request for segayuu, curbengh and a team December 2, 2019 15:27
@SukkaW SukkaW force-pushed the feat_enhance_cache branch from 36d4e56 to 38175d6 Compare December 2, 2019 16:31
@SukkaW SukkaW changed the title [WIP] feat(enhance_cache): bring up feat(enhance_cache): bring up [locals] Dec 2, 2019
@SukkaW SukkaW closed this Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants