Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Expo 48 #159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

saurabbot
Copy link

@saurabbot saurabbot commented Apr 30, 2023

Description

Fixes #157

this pr upgrades expo version to the new expo 48 and have removed expo-cli as expo 48 has expo-cli inbuilt.

Ticket Link

How has this been tested?

Screenshots

Checklist

  • Added a "Closes [issue number]" in the ticket link section
  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens

@netlify
Copy link

netlify bot commented Apr 30, 2023

Deploy Preview for webheylinda failed.

Name Link
🔨 Latest commit e21d60a
🔍 Latest deploy log https://app.netlify.com/sites/webheylinda/deploys/644e29474982460008481818

@saurabbot saurabbot changed the title upgrade done but amplitude bug persists Upgrade to Expo 48 Apr 30, 2023
@saurabbot
Copy link
Author

saurabbot commented Apr 30, 2023

@watadarkstar hey bro could you check this.
Damn, jus realised @abdur-rakib is already made a pr for this... well u can go with the better one ..lol ;P

@watadarkstar watadarkstar self-requested a review July 3, 2023 17:20
Copy link
Collaborator

@watadarkstar watadarkstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the reanimated patch file located in the patches directory? Its failing the build and github action checks are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade expo version to latest & fix upgrade related issue
2 participants