Upgrade expo version to latest & fix upgrade related issue #160
Conversation
✅ Deploy Preview for webheylinda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@watadarkstar Kindly review and let me know if you feel any changes required. |
There was a problem hiding this comment.
Looks good! However, we shouldn't commit the android/ folder can you please add these lines into the .gitignore and un-commit all the files that were committed to the android folder.
We should have this in the .gitignore:
# Android/IntelliJ
#
build/
.idea
.gradle
local.properties
*.iml
*.hprof
.cxx/
android/
Updated |
There was a problem hiding this comment.
There are a few issues:
- We need to fix the types. I tried to fix them myself but need to look into it more. See:
https://reactnavigation.org/docs/typescript/
Run yarn typecheck to see the issues after running a yarn install
- Running
yarn iosfails with the following error:
✔ Installed JavaScript dependencies 1059ms
✖ Config sync failed
Cannot read properties of undefined (reading 'withBitcode')
TypeError: Cannot read properties of undefined (reading 'withBitcode')
at withIosExpoPlugins (/Users/adriancaroll/workspace/github/heylinda/heylinda-app/node_modules/expo-cli/node_modules/@expo/prebuild-config/src/plugins/withDefaultPlugins.ts:58:5)
at getPrebuildConfig (/Users/adriancaroll/workspace/github/heylinda/heylinda-app/node_modules/expo-cli/node_modules/@expo/prebuild-config/src/getPrebuildConfig.ts:51:14)
at configureManagedProjectAsync (/Users/adriancaroll/workspace/github/heylinda/heylinda-app/node_modules/expo-cli/src/commands/eject/configureProjectAsync.ts:54:25)
at prebuildAsync (/Users/adriancaroll/workspace/github/heylinda/heylinda-app/node_modules/expo-cli/src/commands/eject/prebuildAsync.ts:90:21)
at actionAsync (/Users/adriancaroll/workspace/github/heylinda/heylinda-app/node_modules/expo-cli/src/commands/run/ios/runIos.ts:45:5)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
There is something missing probably in this file:
https://docs.expo.dev/workflow/configuration/
@watadarkstar Fixed and verified locally. Kindly let me know if there is anything else. 
|
Description
✅ The following packages were updated:
expo-analytics-amplitude, expo-asset, expo-av, expo-blur, expo-constants, expo-file-system, expo-font, expo-linking, expo-navigation-bar, expo-splash-screen, expo-status-bar, expo-system-ui, expo-tracking-transparency, @expo/vector-icons, expo-web-browser, react, react-dom, react-native, @react-native-async-storage/async-storage, react-native-gesture-handler, react-native-get-random-values, react-native-reanimated, react-native-safe-area-context, react-native-screens, react-native-web, jest-expo, jest, typescript, @babel/core, @types/react, expo
🚨 The following packages were not updated. You should check the READMEs for those repositories to determine what version is compatible with your new set of packages:
@react-native-community/masked-view, @react-navigation/bottom-tabs, @react-navigation/native, @react-navigation/stack, @reduxjs/toolkit, dayjs, expo-analytics, patch-package, postinstall-postinstall, react-native-calendars, react-native-paper, react-redux, redux-persist, uuid, @react-native-community/eslint-config, @testing-library/react-native, @types/jest, @types/react-native, @types/react-native-calendars, @types/uuid, cypress, cz-conventional-changelog, eslint, eslint-plugin-cypress, eslint-plugin-prettier, eslint-plugin-react, eslint-plugin-react-native, expo-cli, husky, lint-staged
Please refer to the release notes for information on any further required steps to update and information about breaking changes:
https://blog.expo.dev/expo-sdk-48-ccb8302e231
In addition to the most recent release notes, you should go over the breaking changes from skipped releases:
Ticket Link
#157
How has this been tested?
I have tested the app by running it in an Android simulator and Android 11 device. I am not sure of all the features offered by the app, so one sanity check required from the reviewer.
Screenshots
Verified in Android device -
23-07-02-19-57-11_ACFmuMeH.mp4
Verified in a simulator -
device-2023-07-02-190258_hLfudhtw.mp4
Checklist