Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript, JSX and TSX language support #64

Merged
merged 10 commits into from
Dec 25, 2023

Conversation

espenja
Copy link
Contributor

@espenja espenja commented Dec 25, 2023

Praise

I think this is a really cool app, and would love to see it succeed further! ❤️

What is this PR?

This pull request adds language support and formatting of TypeScript, JSX, TSX.
Also added is autodetection for TypeScript.
JSX and TSX does not seem to be supported by guesslang-js, so autodetection for these are missing.

TypeScript:

image

TSX:

image

JSX:

image

Tasks

  • Add language support for TypeScript, JSX, TSX
  • Add formatting support for TypeScript, JSX, TSX
  • Add language autodetection for TypeScript

@espenja espenja changed the title Add typescript language Add TypeScript language support Dec 25, 2023
@espenja espenja mentioned this pull request Dec 25, 2023
23 tasks
@espenja espenja changed the title Add TypeScript language support Add TypeScript, JSX and TSX language support Dec 25, 2023
Copy link
Owner

@heyman heyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

If you rebase against main Heynote now have a few end-to-end tests as well that should run.

src/editor/languages.js Outdated Show resolved Hide resolved
@espenja
Copy link
Contributor Author

espenja commented Dec 25, 2023

Three tests are failing after merging in main.
Should this be expected, or have some of my changes broken anything?
image

@heyman
Copy link
Owner

heyman commented Dec 25, 2023

Will take a look! I've just added the tests and I might have messed something up.

@heyman
Copy link
Owner

heyman commented Dec 25, 2023

The tests were broken (for some reason they worked when running in the playwright UI locally). Should be fixed now though!

@heyman heyman merged commit 475f346 into heyman:main Dec 25, 2023
1 check passed
@heyman
Copy link
Owner

heyman commented Dec 26, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants