Add kotlinx-datetime module (#198) #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfhbd
requested changes
Jun 28, 2024
|
|
||
| kotlin.jvmToolchain(11) | ||
|
|
||
| dependencies { |
| allow("MIT") | ||
| } | ||
|
|
||
| publishing { |
| } | ||
| } | ||
|
|
||
| java { |
| import kotlin.random.Random | ||
|
|
||
| @UUIDExperimentalAPI | ||
| public fun UUIDv7(random: Random = SecureRandom): UUID = |
There was a problem hiding this comment.
Don't hardcode Clock System, instead add an Instant parameter, this should be enough.
|
|
||
| @Test | ||
| fun testConversionInstant() { | ||
| val timestamp = Clock.System.now() |
|
Do you want to modify the PR? Otherwise I can take it too. |
|
I can check to see if I find some time within the next week. But if you're quicker, feel free to take over the PR 👍 |
# Conflicts: # gradle/libs.versions.toml
hfhbd
approved these changes
Jun 28, 2024
# Conflicts: # gradle/libs.versions.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
Feel free to modify or decline